Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect empty service.spec.type #106

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Respect empty service.spec.type #106

merged 1 commit into from
Feb 6, 2024

Conversation

blaubaer
Copy link
Member

@blaubaer blaubaer commented Feb 6, 2024

Motivation

Currently if a service does have an empty spec.type it will be treated as an error.

Changes

<empty> is now assumed as ClusterIP.

@blaubaer blaubaer added the bug Something isn't working label Feb 6, 2024
@blaubaer blaubaer self-assigned this Feb 6, 2024
@blaubaer blaubaer merged commit 8b91b02 into main Feb 6, 2024
4 checks passed
@blaubaer blaubaer deleted the respect-empty-service-type branch February 6, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blaubaer blaubaer

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blaubaer