Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Creation #4

Closed
AshleyCheyemi opened this issue Jul 7, 2017 · 4 comments
Closed

Project Creation #4

AshleyCheyemi opened this issue Jul 7, 2017 · 4 comments

Comments

@AshleyCheyemi
Copy link

-- Edit description box will not collapse with either Save or Close; rather, must click outside description box to return to maps
-- What does the Publish selection box in the description of project box mean?
-- Video and Photo...upload? Or insert link?
-- Remove button on map layers not always available (see Buford Maps project)
-- Other than clicking on Projects on top bar, how to access project once saved? How to see multiple saved projects and then select one to view?
-- Can we create a link to share projects (vs. making them public)?
-- “Buford Maps” automatically loaded to Public Projects, even though it is supposed to be my private project

@jayvarner
Copy link
Member

@AshleyCheyemi, thanks for all of these. Some of them I knew about but kept forgetting. It's really helpful to have a list here.

  • Edit description box will not collapse with either Save or Close; rather, must click outside description box to return to maps

In the next code push, Save saves the description and exits the edit mode. The Cancel button now exits edit mode and rolls back any changes.

  • What does the Publish selection box in the description of project box mean?

Wording could be better. If a project is published it can be seen by anyone with the link. A project that is featured will show up on the homepage and on the projects page. Maybe, as you suggest in another question, something like Share Project button that. On the backend, it will mark the project as published. On the front end, it provides a link?

  • Video and Photo...upload? Or insert link?

Link. and only Youtube is currently supported. This needs a lot of work.

  • Remove button on map layers not always available (see Buford Maps project)

It will only show if you are logged in.

  • Other than clicking on Projects on top bar, how to access project once saved? How to see multiple saved projects and then select one to view?

The projects page could be organized better. Other than that, and the home page, what would you expect/like to see?

  • Can we create a link to share projects (vs. making them public)?
    Previous and next response.

"Buford Maps" automatically loaded to Public Projects, even though it is supposed to be my private project

I'm aware of this bug. In short, the projects are not viewable to everyone. I can not see the "Buford Maps" project. It's fixed in the next code push.

Long answer is the backend only returns featured projects. If you are not logged in, the server will only return featured projects. However, if you are logged in, your projects are also loaded into the local store, so they show up when all projects are listed. Fixing it is a matter of adding a filter on that section and will be in the next code push.

@jayvarner jayvarner self-assigned this Jul 7, 2017
jayvarner added a commit that referenced this issue Jul 7, 2017
@jayvarner
Copy link
Member

Remaining work is to add help text defining "Publish"...or change to "Share". We should look at what language Google Docs, Dropbox, etc use.

@jayvarner
Copy link
Member

@ewilloughby the relevant code is here: https://github.com/ecds/ATLMaps-Client/blob/develop/app/templates/project/settings.hbs#L10

For the tooltip, let's look at using something like ember-tooltips.

ewilloughby added a commit that referenced this issue Sep 6, 2017
…tip added for Publish checkbox in project settings per issue #4
@ewilloughby
Copy link
Collaborator

ewilloughby commented Sep 6, 2017

Added a hover tooltip for "Publish" using ember-tooltips to clarify what this checkbox does.
image

aaaf7e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants