Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client print detail improvements #3861

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Client print detail improvements #3861

merged 4 commits into from
Sep 29, 2023

Conversation

carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented Sep 29, 2023 •
edited
Loading

Fixes the following things in client print:

  • Variable font size on schedule entries on picasso: In very short schedule entries, the font size is scaled down such that at least one full line of text is always visible on the schedule entry. This has been a point which has been criticised in the feedback we got.
  • Font coloring of picasso schedule entries: This was probably broken in 3d4c73e
  • Work around a bug in react-pdf layouting, which could cause an infinite loop. This would happen very rarely, but on dev you can try to print the Star Wars camp, and it will never complete. On the feature branch deployment, this should be fixed. See commit message for details.

@carlobeltrame
Adjust font size for extremely short schedule entries
ceb3b0f
@carlobeltrame
Fix font coloring
1d3e45e 
This probably broke in 3d4c73e
@carlobeltrame
Work around react-pdf bug
49c0099 
Until diegomura/react-pdf#2400 is merged,
react-pdf can sometimes fall into an infinite loop during layouting,
when a min-presence-ahead element has a following sibling with vertical
margins. This caused our Star Wars example camp to be unprintable.
The bug does not happen with vertical padding, so this workaround will
fix the problem for now.
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Sep 29, 2023
@carlobeltrame carlobeltrame temporarily deployed to feature-branch September 29, 2023 12:47 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame temporarily deployed to feature-branch September 29, 2023 12:48 — with GitHub Actions Inactive
@carlobeltrame carlobeltrame temporarily deployed to feature-branch September 29, 2023 12:52 — with GitHub Actions Inactive
@pmattmann pmattmann added this pull request to the merge queue Sep 29, 2023
Merged via the queue into ecamp:devel with commit b332a99 Sep 29, 2023
23 checks passed
@carlobeltrame carlobeltrame deleted the variable-font-size branch September 29, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BacLuc BacLuc BacLuc approved these changes

@pmattmann pmattmann pmattmann approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlobeltrame @pmattmann @BacLuc