fix: the idx of a pair inside or inside pair is not calculated correctly

[ac10n]

Closes #2927
Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

• Your code builds cleanly without any errors or warnings
• You have run the linter against the changes
• You have added unit tests (if relevant/appropriate)
• You have added integration tests (if relevant/appropriate)
• All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
• You have added or updated corresponding documentation
• If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

• You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
• You have added a concise description on your changes

Release Note Draft Snippet

This is a breaking change in (In API behaviour, not the API itself).
Previously, when Michelson Data was converted to javascript objects (For instance, by calling storage method of a contract abstraction), in the following scenario we would have an unexpected behaviour:

1. The javascript representation has nested objects, like having a pair, inside an or inside another pair
2. Some of the pair's items don't have annots.

In this case, the the resulting javascript object would look like this

{
  '0': 'firstValue',
  '1': 'secondValue,
  '2': {
   '2': 'thirdValue',
   '3': 'fourthValue'
  }

Please note the the inner object's field numbers depend on the object's location in it's parent, and starts with '2' in this example. With this PR, this changes to:

{
  '0': 'firstValue',
  '1': 'secondValue,
  '2': {
   '0': 'thirdValue',
   '1': 'fourthValue'
  }

If your dApp code depends on the old behaviour (or changing it requires too much effort, you can call Tezos.setFieldNumberingStrategy('Legacy') to keep thew previous behaviour. But please note that in a future release, this option might be removed.

[github-actions]

A new deploy preview is available on Cloudflare Pages at https://8ac783f0.taquito-test-dapp.pages.dev

[github-actions]

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

[cloudflare-workers-and-pages]

Deploying taquito with    Cloudflare Pages

Latest commit:	c49e550
Status:	✅  Deploy successful!
Preview URL:	https://133be780.taquito.pages.dev
Branch Preview URL:	https://2927-variant-typing-bug.taquito.pages.dev

View logs