Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wrong order on tutorial docs #2913

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Updated wrong order on tutorial docs #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f36074c
updated taquito/beacon-wallet readme to match current beacon implemen…
dsawali Apr 9, 2024
410e832
addressed PR comments
dsawali Apr 10, 2024
eb3723e
updated originate.md
dsawali Apr 10, 2024
78c5fde
remove eventHandlers property
dsawali Apr 11, 2024
1a0cec8
Merge branch 'master' of github.com:ecadlabs/taquito into 2908-update…
dsawali Apr 11, 2024
7e89089
updated wrong order on wallet initialization docs
dsawali Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/originate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ import { TezosToolkit } from '@taquito/taquito';
const Tezos = new TezosToolkit('https://ghostnet.ecadinfra.com');
const option = { name: "nameOfWallet", network: { type: 'ghostnet' }, enableMetrics: true};
const wallet = new BeaconWallet(option);
await wallet.requestPermissions();
Tezos.setWalletProvider(wallet);

await wallet.client.subscribeToEvent(
BeaconEvent.ACTIVE_ACCOUNT_SET,
Expand All @@ -58,6 +56,8 @@ await wallet.client.subscribeToEvent(
console.log(`${BeaconEvent.ACTIVE_ACCOUNT_SET} triggered: `, account);
},

await wallet.requestPermissions();
Tezos.setWalletProvider(wallet);
```

</TabItem>
Expand Down
3 changes: 1 addition & 2 deletions packages/taquito-beacon-wallet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,14 @@ const options = {
};
const wallet = new BeaconWallet(options);

await wallet.requestPermissions();

await wallet.client.subscribeToEvent(
BeaconEvent.ACTIVE_ACCOUNT_SET,
async (account) => {
// An active account has been set, update the dApp UI
console.log(`${BeaconEvent.ACTIVE_ACCOUNT_SET} triggered: `, account);
},
);
await wallet.requestPermissions();

const Tezos = new TezosToolkit('https://YOUR_PREFERRED_RPC_URL');
Tezos.setWalletProvider(wallet);
Expand Down
4 changes: 2 additions & 2 deletions website/versioned_docs/version-19.2.0/originate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ import { TezosToolkit } from '@taquito/taquito';
const Tezos = new TezosToolkit('https://ghostnet.ecadinfra.com');
const option = { name: "nameOfWallet", network: { type: 'ghostnet' }, enableMetrics: true};
const wallet = new BeaconWallet(option);
await wallet.requestPermissions();

await wallet.client.subscribeToEvent(
BeaconEvent.ACTIVE_ACCOUNT_SET,
async (account) => {
// An active account has been set, update the dApp UI
console.log(`${BeaconEvent.ACTIVE_ACCOUNT_SET} triggered: `, account);
},


await wallet.requestPermissions();
Tezos.setWalletProvider(wallet)
```

Expand Down
Loading