Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated taquito/beacon-wallet readme to match beacon implementation #2910

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

dsawali
Copy link
Contributor

@dsawali dsawali commented Apr 10, 2024

closes #2908

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

github-actions bot commented Apr 10, 2024

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

Copy link

github-actions bot commented Apr 10, 2024

A new deploy preview is available on Netlify at https://f013678--tezostaquito.netlify.app

@dsawali dsawali marked this pull request as ready for review April 10, 2024 19:21
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments in files
Also, would be good to update docs/originate.md line 51 with subscribeToEvent too (and 19.2.0 versioned doc).
Our website ins't using subscribeToEvent either and getting warning in console with An active account has been received, but no active subscription was found for BeaconEvent.ACTIVE_ACCOUNT_SET. For more information, visit: https://docs.walletbeacon.io/guides/migration-guide

@dsawali
Copy link
Contributor Author

dsawali commented Apr 10, 2024

Left a couple small comments in files Also, would be good to update docs/originate.md line 51 with subscribeToEvent too (and 19.2.0 versioned doc). Our website ins't using subscribeToEvent either and getting warning in console with An active account has been received, but no active subscription was found for BeaconEvent.ACTIVE_ACCOUNT_SET. For more information, visit: https://docs.walletbeacon.io/guides/migration-guide

updating originate.md is a good idea, but I will not be updating the website in this ticket. We can create a ticket and request @ac10n's help to implement the change

Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2024

Deploying taquito with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78c5fde
Status: ✅  Deploy successful!
Preview URL: https://e7689b69.taquito.pages.dev
Branch Preview URL: https://2908-update-readme.taquito.pages.dev

View logs

Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge once the order is updated, thanks for prompt update!

Copy link

A new deploy preview is available on Cloudflare Pages at https://fe704b91.taquito-test-dapp.pages.dev

@dsawali dsawali merged commit 4360f9c into master Apr 11, 2024
10 checks passed
@dsawali dsawali deleted the 2908-update-readme branch April 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beacon-wallet] Update the README file (and documentation) to include an ACTIVE_ACCOUNT_SET listener
2 participants