-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated taquito/beacon-wallet readme to match beacon implementation #2910
Conversation
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
A new deploy preview is available on Netlify at https://f013678--tezostaquito.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple small comments in files
Also, would be good to update docs/originate.md
line 51 with subscribeToEvent
too (and 19.2.0 versioned doc).
Our website ins't using subscribeToEvent
either and getting warning in console with An active account has been received, but no active subscription was found for BeaconEvent.ACTIVE_ACCOUNT_SET. For more information, visit: https://docs.walletbeacon.io/guides/migration-guide
updating originate.md is a good idea, but I will not be updating the website in this ticket. We can create a ticket and request @ac10n's help to implement the change |
Deploying taquito with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge once the order is updated, thanks for prompt update!
A new deploy preview is available on Cloudflare Pages at https://fe704b91.taquito-test-dapp.pages.dev |
closes #2908
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.