Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(michelson encoder): improved Errors in the Michelson Encoder Package #2551

Merged
merged 6 commits into from
Jul 11, 2023
Merged

chore(michelson encoder): improved Errors in the Michelson Encoder Package #2551

merged 6 commits into from
Jul 11, 2023

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Jul 4, 2023 •
edited
Loading

Refactored errors in the Michelson Encoder package to have better messages and be more informative to the user

closes #1995

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@ac10n
chore(michelson encoder): improved Errors in the Michelson Encoder Pa…
3b17d7c 
…ckage

Refactored errors in the Michelson Encoder package to have better messages and be more informative
to the user

closes #1995
@netlify
Copy link

netlify bot commented Jul 4, 2023 •
edited
Loading

✅ Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 7f90b69
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/64a846a912ab7b0008c08d4f
😎 Deploy Preview https://deploy-preview-2551--taquito-test-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023 •
edited
Loading

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Jul 4, 2023 •
edited
Loading

A new deploy preview is available on Netlify at https://e9f6afd--tezostaquito.netlify.app

@ac10n ac10n marked this pull request as ready for review July 5, 2023 22:15
@ac10n ac10n requested review from dsawali and hui-an-yang July 6, 2023 16:42
@ac10n ac10n requested review from dsawali and hui-an-yang July 7, 2023 17:10
@ac10n ac10n merged commit da819a0 into master Jul 11, 2023
11 of 12 checks passed
@ac10n ac10n deleted the 1995-improve-errors-in-michelson-encoder-package branch July 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsawali dsawali dsawali approved these changes

@hui-an-yang hui-an-yang Awaiting requested review from hui-an-yang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error in the Michelson-Encoder package
3 participants
@ac10n @dsawali @hui-an-yang