Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the injector to the TezosToolkit class #1344

Closed
roxaneletourneau opened this issue Jan 21, 2022 · 1 comment · Fixed by #2445
Closed

Expose the injector to the TezosToolkit class #1344

roxaneletourneau opened this issue Jan 21, 2022 · 1 comment · Fixed by #2445
Assignees
@hui-an-yang
Labels
3 enhancement New feature or request ux/dx Related to Developer Experience
Milestone
v17.1

Comments

@roxaneletourneau
Copy link
Collaborator

Is your feature request related to a problem and use case? Please describe.
An injector property is present in the Context class and set by default to an instance of RpcInjector. There is no easy way for the users to customize or override the injector.

Describe the solution you'd like
Allows easy customization of the injector by adding a setInjectorProvider method on the TezosToolkit class.

Additional context
When using the current implementation of the RpcInjector, the RPC waits for the operation to be (pre-)validated before returning the operation hash.

The RPC /injection/operation endpoint has an optional property name async, which when set to true, skips the (pre-)validated and returns immediately.

By providing access to the injector, users will be able to skip this validation if needed.
@Innkst Innkst added this to the v11.4 milestone Feb 4, 2022
@Innkst Innkst modified the milestones: v12.1, v12.2 Mar 18, 2022
@Innkst Innkst added enhancement New feature or request ux/dx Related to Developer Experience labels Dec 29, 2022
@Innkst Innkst modified the milestones: v15.1, v16.1 Dec 29, 2022
@dsawali
Copy link
Contributor

dsawali commented Feb 16, 2023

Hey team! Please add your planning poker estimate with Zenhub @AlirezaHaghshenas @hui-an-yang @zainen

@Innkst Innkst modified the milestones: v16.1, v16.2 Mar 11, 2023
@Innkst Innkst modified the milestones: v16.2, v17.1 Apr 15, 2023
hui-an-yang added a commit that referenced this issue Apr 19, 2023
@hui-an-yang
feat: expose RpcInjector in TezosToolKit
c6a01a2 
re #1344
@Innkst Innkst added the 3 label Jun 2, 2023
@hui-an-yang hui-an-yang linked a pull request Jul 10, 2023 that will close this issue
1344 expose injector in tezos tool kit #2445
Merged
9 tasks
@hui-an-yang hui-an-yang self-assigned this Jul 10, 2023
hui-an-yang added a commit that referenced this issue Jul 11, 2023
@hui-an-yang
1344 expose injector in tezos tool kit (#2445)
78a882a 
* feat: expose RpcInjector in TezosToolKit

re #1344

* test: adding integration test and export rpcInjector

* refactor: addressed pr comments
@dsawali dsawali mentioned this issue Jul 11, 2023
Merged
9 tasks
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
3 enhancement New feature or request ux/dx Related to Developer Experience
Projects
Taquito Dev
Status: Done
Milestone
v17.1
Development

Successfully merging a pull request may close this issue.

1344 expose injector in tezos tool kit ecadlabs/taquito
4 participants
@dsawali @roxaneletourneau @Innkst @hui-an-yang