Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix(pagination): Fixing markup for links without icons - front-1574 #557

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Sep 8, 2020

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: bug fix labels Sep 8, 2020
@planctus planctus changed the title fix(pagination): fixing markup for links whithout icons - front-1574 fix(pagination): Fixing markup for links without icons - front-1574 Sep 9, 2020
@kalinchernev kalinchernev merged commit a58f721 into develop Sep 10, 2020
@kalinchernev kalinchernev deleted the front-1574 branch September 10, 2020 05:27
@kalinchernev kalinchernev removed the pr: review needed Use this label to show that your PR needs to be review label Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants