Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

chore(pipeline): replacing dubnium with erbium - front-1439 #520

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Aug 3, 2020

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: internal labels Aug 3, 2020
@kalinchernev kalinchernev self-assigned this Aug 12, 2020
@kalinchernev kalinchernev merged commit 262f8ab into develop Aug 12, 2020
@kalinchernev kalinchernev deleted the front-1439 branch August 12, 2020 08:24
@kalinchernev kalinchernev removed their assignment Aug 12, 2020
@kalinchernev kalinchernev removed the pr: review needed Use this label to show that your PR needs to be review label Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants