feat(stories): Migration to CSF format - FRONT-1117 #489
Conversation
planctus
added
pr: review needed
|
Please resolve conflicts |
|
@kalinchernev, conflicts fixed ;) |
babel.config.js
Outdated
| plugins: ['preval'], | ||
| plugins: [ | ||
| [ | ||
| '@babel/transform-runtime', |
There was a problem hiding this comment.
That was needed for the script to migrate to run. But i have seen many times an error in the console for the missing regenerator-runtime in certain situations, so i thought that this would also be the way to fix that. Unfortunately i don't have "proof" about this, because i cannot reproduce the issue i described.
So if you think there are downsides of using this plugin we can remove it for now and reintegrate it only if we experience again the issue i mentioned.
There was a problem hiding this comment.
For the script to run, ok. If it's not required after the work of the script and you're not sure about the benefits, I'd remove it, but it's up to you
There was a problem hiding this comment.
removed it @kalinchernev ;)
kalinchernev
removed
the
pr: review needed
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)