refactor(knobs): Datepicker - Mandatory/optional knobs - FRONT-905 #390
Conversation
Joosthe
changed the title
|
@Joosthe this ticket: i see it has not been added so i wonder what you based this work on. |
|
Since the knobs were already there i set the knobs i based the cases on the variants. the optional elements are the elements that are visible if one of the cases is true |
Joosthe
added
pr: review needed
|
Yep, @Joosthe , i thought i edited the comment replacing the "i see it has not been added so i wonder what you based this work on." with " i see that what you did makes sense, i will unflag the ticket" right after taking a look at the code, but i didn't publish it sorry, i removed the flag on the ticket instead, that i did it for real.. :) |
planctus
added
pr: under review
and removed
pr: review needed
| data.optional_text, | ||
| buttonLabels.optional | ||
| ); | ||
| data.placeholder = text( |
There was a problem hiding this comment.
i think for now you can move this into the optional parameters, as we know there is no documentation page to base this on, but yeah, it looks more like an "option" than a requirement
There was a problem hiding this comment.
You haven't changed this, but since there is no official docs about what is required and what is not for this component we can leave this as required.
Joosthe
added
pr: review needed
planctus
added
pr: under review
and removed
pr: review needed
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)