You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 2, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
I have put the vanilla component as devDependencies
I have put the specs package as devDependencies
I have added the components directly used in the twig file (with include or embed) as dependencies
My component is listed in @ecl-twig/ec-components's dependencies
My variables naming follow the guidelines (snake case for twig)
I have provided tests
I have provided documentation (for the "notes" tab)
If my local yarn.lock contains changes, I have committed it
I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)
@planctus Looks really much improved and thanks for all the work, the only thing i could find on the component is that the icon is missing now in the preview of the component
No, @Joosthe , the icon is there: https://5e73a38ee6b9de0ee0b17d46--ecl-twig.netlify.com/ec/?path=/story/components-banners-hero-banner--image
I think you just need to update the plugin for the story-utils, sorry not to point this out in advance, but as usual, when we have changes in one of our plugins we need to pay attention to really update it on our local environments.
So, you can remove the node-modules folder and run yarn again or you can copy the index.js file from the working tree (utils/story-utils/src/index.js) to the package in the node_modules folder (node-modules/@ecl-twig/story-utils/src/index.js).
I hope this is the last time i have to write this, but it's true that might maybe find a solution for this beacuse i see that everytime is an issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependencies
devDependencies
include
orembed
) asdependencies
@ecl-twig/ec-components
'sdependencies
yarn.lock
contains changes, I have committed itpr: review needed
to indicate that I'm done and now waiting for a review ,pr: wip
to indicate that I'm actively working on it ...)