Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

refactor(demo): Text Area, States, optional/mandatory knobs - FRONT-904 #364

Merged
merged 11 commits into from
Mar 18, 2020

Conversation

planctus
Copy link
Contributor

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: enhancement labels Mar 12, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Mar 13, 2020
@planctus planctus added the pr: wip Mark the PR as WIP label Mar 16, 2020
@planctus planctus added pr: review needed Use this label to show that your PR needs to be review and removed pr: under review pr: wip Mark the PR as WIP labels Mar 17, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Mar 18, 2020
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@planctus just added a small update, but for me you can merge 👍

@planctus planctus merged commit ca993a8 into develop Mar 18, 2020
@planctus planctus deleted the FRONT-904 branch March 18, 2020 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants