This repository has been archived by the owner on May 2, 2023. It is now read-only.
fix(button): fixing the example in the notes tab, improving knobs - FRONT-893 #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This is better visible with the fix applied on the storybook plugin for notes in #350.
we recently worked on the button introducing knobs, but with the fix applied to the notes tab it was showing the icon object always, because we were setting it by default, with a "null" name which was enough not to get any markup generated.
Now the icon is only "added" when the select for the name is not "null", so when an icon is supposed to be shown.
I added knobs for the icon, with a new approach:
sometimes we want to show a knob without really letting the user interact with it, i was looking for a solution to "disable" a knob, but it's actually easier to just define it as a select where the only available value is the selected one. This way we show the property but we don't let the user change it, this has been applied to the icon size and the icon type.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependencies
devDependencies
include
orembed
) asdependencies
@ecl-twig/ec-components
'sdependencies
yarn.lock
contains changes, I have committed itpr: review needed
to indicate that I'm done and now waiting for a review ,pr: wip
to indicate that I'm actively working on it ...)