Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix(button): fixing the example in the notes tab, improving knobs - FRONT-893 #351

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Mar 4, 2020

PR description

This is better visible with the fix applied on the storybook plugin for notes in #350.
we recently worked on the button introducing knobs, but with the fix applied to the notes tab it was showing the icon object always, because we were setting it by default, with a "null" name which was enough not to get any markup generated.
Now the icon is only "added" when the select for the name is not "null", so when an icon is supposed to be shown.
I added knobs for the icon, with a new approach:
sometimes we want to show a knob without really letting the user interact with it, i was looking for a solution to "disable" a knob, but it's actually easier to just define it as a select where the only available value is the selected one. This way we show the property but we don't let the user change it, this has been applied to the icon size and the icon type.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: enhancement labels Mar 4, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Mar 9, 2020
@papegaill papegaill merged commit 7f4f863 into develop Mar 9, 2020
@papegaill papegaill deleted the FRONT-893 branch March 9, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants