Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

feat(knobs): fact and figures show/hiding elements and grouping knobs - FRONT-866 #349

Merged
merged 7 commits into from
Mar 3, 2020

Conversation

Joosthe
Copy link
Contributor

@Joosthe Joosthe commented Feb 28, 2020

… - FRONT-866

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: wip Mark the PR as WIP and removed in progress labels Feb 28, 2020
@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: enhancement and removed pr: wip Mark the PR as WIP labels Feb 28, 2020
@planctus planctus added pr: wip Mark the PR as WIP and removed pr: review needed Use this label to show that your PR needs to be review labels Mar 2, 2020
@planctus planctus added pr: review needed Use this label to show that your PR needs to be review and removed pr: wip Mark the PR as WIP labels Mar 2, 2020
@Joosthe Joosthe added the pr: wip Mark the PR as WIP label Mar 2, 2020
@planctus planctus removed the pr: review needed Use this label to show that your PR needs to be review label Mar 2, 2020
@Joosthe Joosthe added pr: review needed Use this label to show that your PR needs to be review and removed pr: wip Mark the PR as WIP labels Mar 2, 2020
@planctus planctus removed the pr: review needed Use this label to show that your PR needs to be review label Mar 3, 2020
@planctus planctus merged commit f37543a into develop Mar 3, 2020
@planctus planctus deleted the FRONT-866 branch March 3, 2020 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants