Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

feat(Pagination): added knob Aria label - FRONT-488 #336

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

Joosthe
Copy link
Contributor

@Joosthe Joosthe commented Feb 11, 2020

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@Joosthe Joosthe added pr: review needed Use this label to show that your PR needs to be review tag: enhancement labels Feb 11, 2020
@papegaill papegaill merged commit 4e93f0e into develop Feb 11, 2020
@papegaill papegaill deleted the FRONT-488 branch February 11, 2020 16:45
@papegaill papegaill removed the pr: review needed Use this label to show that your PR needs to be review label Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants