Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix(php-storybook): English logo fixed - FRONT-484 #328

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Feb 7, 2020

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: bug fix labels Feb 7, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Feb 10, 2020
@papegaill papegaill merged commit 347fa68 into develop Feb 10, 2020
@papegaill papegaill deleted the FRONT-484 branch February 10, 2020 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants