Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

feat(language-list): Icon removed - TWIG-165 #261

Merged
merged 2 commits into from
Dec 10, 2019
Merged

feat(language-list): Icon removed - TWIG-165 #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b461f1f
feat(langauge-list): Icon removed - TWIG-165
planctus Dec 6, 2019
31f7935
feat(language-list): Other tests needed an update - TWIG-165
planctus Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions src/ec/packages/ec-component-language-list/__snapshots__/language-list.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,6 @@ exports[`EC - Language List Overlay renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -452,15 +443,6 @@ exports[`EC - Language List Overlay renders correctly with extra attributes 1`]
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -858,15 +840,6 @@ exports[`EC - Language List Overlay renders correctly with extra class names 1`]
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down
9 changes: 0 additions & 9 deletions src/ec/packages/ec-component-language-list/ecl-language-list-overlay.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,6 @@
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
{% include '@ecl-twig/ec-component-icon/ecl-icon.html.twig' with {
icon: {
path: _icon_path,
type: "general",
name: "generic-lang",
size: "m"
},
extra_classes: "ecl-language-list__title-icon"
} only %}
{{- _title -}}
</div>
</div>
Expand Down
1 change: 0 additions & 1 deletion src/ec/packages/ec-component-language-list/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"description": "ECL Twig - EC Language List",
"dependencies": {
"@ecl-twig/ec-component-button": "2.17.3",
"@ecl-twig/ec-component-icon": "2.17.3",
"@ecl-twig/ec-component-link": "2.17.3"
},
"devDependencies": {
Expand Down
63 changes: 0 additions & 63 deletions src/ec/packages/ec-component-site-header-core/__snapshots__/site-header-core.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,6 @@ exports[`EC - Site Header Core Default renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -771,15 +762,6 @@ exports[`EC - Site Header Core Default renders correctly when logged in 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -1325,15 +1307,6 @@ exports[`EC - Site Header Core Default renders correctly with extra attributes 1
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -1877,15 +1850,6 @@ exports[`EC - Site Header Core Default renders correctly with extra class names
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -2429,15 +2393,6 @@ exports[`EC - Site Header Core Translated renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Choisissez votre langue
</div>
</div>
Expand Down Expand Up @@ -2983,15 +2938,6 @@ exports[`EC - Site Header Core Translated renders correctly with extra attribute
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Choisissez votre langue
</div>
</div>
Expand Down Expand Up @@ -3535,15 +3481,6 @@ exports[`EC - Site Header Core Translated renders correctly with extra class nam
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Choisissez votre langue
</div>
</div>
Expand Down
54 changes: 0 additions & 54 deletions ...ges/ec-component-site-header-harmonised/__snapshots__/site-header-harmonised.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,15 +394,6 @@ exports[`EC - Site Header Harmonised Group 1 renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -1153,15 +1144,6 @@ exports[`EC - Site Header Harmonised Group 1 renders correctly with extra attrib
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -1910,15 +1892,6 @@ exports[`EC - Site Header Harmonised Group 1 renders correctly with extra class
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -2444,15 +2417,6 @@ exports[`EC - Site Header Harmonised Group 2 renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -2980,15 +2944,6 @@ exports[`EC - Site Header Harmonised Group 2 renders correctly with extra attrib
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -3514,15 +3469,6 @@ exports[`EC - Site Header Harmonised Group 2 renders correctly with extra class
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down
63 changes: 0 additions & 63 deletions ...ec-component-site-header-standardised/__snapshots__/site-header-standardised.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,15 +394,6 @@ exports[`EC - Site Header Standardised Default renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -1181,15 +1172,6 @@ exports[`EC - Site Header Standardised Default renders correctly when logged in
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -1940,15 +1922,6 @@ exports[`EC - Site Header Standardised Default renders correctly with extra attr
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -2697,15 +2670,6 @@ exports[`EC - Site Header Standardised Default renders correctly with extra clas
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Select your language
</div>
</div>
Expand Down Expand Up @@ -3454,15 +3418,6 @@ exports[`EC - Site Header Standardised Translated renders correctly 1`] = `
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Choisissez votre langue
</div>
</div>
Expand Down Expand Up @@ -4213,15 +4168,6 @@ exports[`EC - Site Header Standardised Translated renders correctly with extra a
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Choisissez votre langue
</div>
</div>
Expand Down Expand Up @@ -4970,15 +4916,6 @@ exports[`EC - Site Header Standardised Translated renders correctly with extra c
class="ecl-language-list__title ecl-col-12 ecl-col-lg-8 ecl-offset-lg-2"
id="ecl-language-list__title"
>
<svg
aria-hidden="true"
class="ecl-icon ecl-icon--m ecl-language-list__title-icon"
focusable="false"
>
<use
xlink:href="/icons.svg#general--generic-lang"
/>
</svg>
Choisissez votre langue
</div>
</div>
Expand Down
Loading