This repository has been archived by the owner on May 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
added
pr: review needed
Use this label to show that your PR needs to be review
and removed
pr: wip
Mark the PR as WIP
labels
Feb 18, 2019
yhuard
removed
the
pr: review needed
Use this label to show that your PR needs to be review
label
Feb 19, 2019
yhuard
suggested changes
Feb 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a nutshell:
- rename parameters
- fix tests
- discuss dependencies
src/ec/packages/ec-component-text-input/__snapshots__/text-input.test.js.snap
Show resolved
Hide resolved
src/ec/packages/ec-component-text-input/__snapshots__/text-input.test.js.snap
Show resolved
Hide resolved
…a/ecl-twig into ec-component-text-input
emeryro
added
pr: review needed
Use this label to show that your PR needs to be review
and removed
pr: wip
Mark the PR as WIP
labels
Feb 19, 2019
degliwe
added
pr: under review
and removed
pr: review needed
Use this label to show that your PR needs to be review
labels
Feb 20, 2019
degliwe
approved these changes
Feb 20, 2019
yhuard
suggested changes
Feb 20, 2019
yhuard
approved these changes
Feb 20, 2019
yhuard
removed
pr: review needed
Use this label to show that your PR needs to be review
pr: under review
labels
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component text input (EC and EU)