Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

feat: component text input #20

Merged
merged 12 commits into from
Feb 20, 2019
Merged

feat: component text input #20

merged 12 commits into from
Feb 20, 2019

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Feb 13, 2019

Add component text input (EC and EU)

@emeryro emeryro added the pr: wip Mark the PR as WIP label Feb 13, 2019
@emeryro emeryro self-assigned this Feb 13, 2019
@emeryro emeryro added pr: review needed Use this label to show that your PR needs to be review and removed pr: wip Mark the PR as WIP labels Feb 18, 2019
@emeryro emeryro removed their assignment Feb 18, 2019
@yhuard yhuard self-assigned this Feb 19, 2019
@yhuard yhuard removed the pr: review needed Use this label to show that your PR needs to be review label Feb 19, 2019
Copy link
Contributor

@yhuard yhuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a nutshell:

  • rename parameters
  • fix tests
  • discuss dependencies

@yhuard yhuard removed their assignment Feb 19, 2019
@emeryro emeryro self-assigned this Feb 19, 2019
@emeryro emeryro added the pr: wip Mark the PR as WIP label Feb 19, 2019
@emeryro emeryro added pr: review needed Use this label to show that your PR needs to be review and removed pr: wip Mark the PR as WIP labels Feb 19, 2019
@emeryro emeryro removed their assignment Feb 19, 2019
@degliwe degliwe self-assigned this Feb 20, 2019
@degliwe degliwe added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Feb 20, 2019
@yhuard yhuard merged commit ee0c571 into master Feb 20, 2019
@yhuard yhuard deleted the ec-component-text-input branch February 20, 2019 13:00
@yhuard yhuard removed pr: review needed Use this label to show that your PR needs to be review pr: under review labels Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants