Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

chore(data-utils): creating set of utilities for transforming the input data #185

Merged
merged 9 commits into from
Oct 25, 2019

Conversation

planctus
Copy link
Contributor

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added the pr: review needed Use this label to show that your PR needs to be review label Oct 24, 2019
@planctus planctus marked this pull request as ready for review October 24, 2019 12:02
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I say? Love this ! 🙏

@papegaill papegaill merged commit 75ad804 into develop Oct 25, 2019
@papegaill papegaill deleted the chore-data-utils branch October 25, 2019 09:40
planctus added a commit that referenced this pull request Oct 25, 2019
…ut data (#185)

* chore(data-utils): tests green, still partial

* chore(data-utils): applying to language list component data

* chore(data-utils): removing unused dependency

* chore(data-utils): removing empty import

* feat(data-utils): applying to footer core
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: review needed Use this label to show that your PR needs to be review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants