Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

feat(text-input): adding extra classes for label, renaming prop TWIG-52 #150

Merged
merged 3 commits into from
Sep 20, 2019

Conversation

planctus
Copy link
Contributor

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus changed the title feat(text-input) : adding extra classes for label, renaming prop TWIG-52 feat(text-input): adding extra classes for label, renaming prop TWIG-52 Sep 20, 2019
@planctus planctus added the pr: review needed Use this label to show that your PR needs to be review label Sep 20, 2019
@emeryro emeryro self-assigned this Sep 20, 2019
@emeryro emeryro added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Sep 20, 2019
@emeryro emeryro merged commit 9b60066 into v2.11-dev Sep 20, 2019
@emeryro emeryro deleted the TWIG-52 branch September 20, 2019 12:38
@emeryro emeryro removed their assignment Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants