This repository has been archived by the owner on May 2, 2023. It is now read-only.
feat(description-list): horizontal variant - TWIG-39 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
added
the
pr: review needed
papegaill
reviewed
Sep 18, 2019
papegaill
reviewed
Sep 18, 2019
src/ec/packages/ec-component-description-list/description-list.html.twig
Outdated
Show resolved
Hide resolved
papegaill
suggested changes
Sep 18, 2019
papegaill
added
pr: modification needed
and removed
pr: review needed
planctus
added
pr: review needed
emeryro
added
pr: under review
and removed
pr: review needed
emeryro
suggested changes
Sep 20, 2019
| @@ -47,6 +47,43 @@ exports[`EC - Description list Default renders correctly 1`] = ` | |||
| </dl> | |||
| `; | |||
|
|
|||
| exports[`EC - Description list Default renders correctly in the horizontal variant 1`] = ` | |||
| <dl | |||
| class="ecl-description-list" | |||
There was a problem hiding this comment.
this is not the horizontal version tested here (missing css class)
There was a problem hiding this comment.
Oh, true, i assumed that the variant was coming from the spec package without checking it...
planctus
added
pr: review needed
emeryro
approved these changes
Sep 20, 2019
|
Looks good for me. |
papegaill
approved these changes
Sep 25, 2019
emeryro
removed
the
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)