feat(menu-legacy): menu-legacy twig implementation - TWIG-5 #119
Conversation
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "postinstall": "lerna run postinstall && lerna run prepublish", | |||
| "pretty-check": "prettier --check \"src/**/*.{md,mdx,html,json,yml,js}\"", | |||
| "publish": "scripts/publish.sh", | |||
| "start:ec": "start-storybook -p 9001 -c ./src/ec/.storybook", | |||
| "start:ec": "start-storybook -p 8082 -c ./src/ec/.storybook", | |||
There was a problem hiding this comment.
is there a reason why you changed this port? This may affect other people working on the project too.
There was a problem hiding this comment.
The reason is I'm working on Cloud9 and there is no port 9001 on it.
but this file does not be pushed.
I fix it then maybe it's better I add this file in gitignore.
There was a problem hiding this comment.
If you have to change the port, that's not really an issue, but you just have to syncronize with other people working on the project to ensure that it won't cause trouble.
I don't recommand to put this file in gitignore anyways.
| @@ -0,0 +1,46 @@ | |||
| # ECL Twig - EC Navidation Menu | |||
|
|
|||
| npm package: `@ecl-twig/ec-component-navigation-menu` | |||
There was a problem hiding this comment.
component name should be updated here (and next line too)
There was a problem hiding this comment.
ok. I also write the right example...
|
|
||
| Parameters: | ||
|
|
||
| - "title" (string) (default: '') |
There was a problem hiding this comment.
parameters do not seems to be up to date (here and in example below)
| "children" (array) (default: []): [{ | ||
| "items" (array) (default: [{}]): [{ | ||
| - "label" (string): label of the link | ||
| - "href" (string): target of the link |
There was a problem hiding this comment.
children items can have a isCurrent parameter too
| <nav data-ecl-auto-init="MenuLegacy" class="{{ _css_class }}" data-ecl-menu-legacy="true" aria-expanded="false" {{ _extra_attributes|raw }}> | ||
| <div class="ecl-container"> | ||
| <button class="{{ _prefix_class }}__toggle {{ _prefix_class }}__hamburger ecl-button ecl-button--ghost" type="button" data-ecl-menu-legacy-hamburger-button="true" > | ||
| <div class="ecl-menu-legacy__toggle-container"> |
There was a problem hiding this comment.
these classes name should use _prefix_class to be consistent (that's the same for some other classes in this file)
or you don't use a prefix at all, it's up to you :)
serotonine
added
pr: review needed
emeryro
added
pr: under review
and removed
pr: review needed
|
The component is good. |
serotonine
added
pr: review needed
emeryro
removed
the
pr: review needed
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)