This repository has been archived by the owner on May 2, 2023. It is now read-only.
feat(file): add download link per translation - INNO-1581 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuard
added
pr: wip
emeryro
added
pr: under review
and removed
pr: review needed
emeryro
suggested changes
Jun 28, 2019
| @@ -9,6 +9,7 @@ npm install --save @ecl-twig/ec-component-file | |||
| ## Parameters | |||
|
|
|||
| - "icon" (object) (default: {}): object of type Icon; file type | |||
| - "icon_path" (string) (default: ''): path to the icon file | |||
There was a problem hiding this comment.
We have an issue here.
Icon path is already part of the icon component. So having it in two different places is confusing.
In some components we have this kind of extra parameters, but in most of them it is part of the Icon structure.
This has to be harmonized.
I'm not in favor of adding duplicate parameter.
There was a problem hiding this comment.
Mostly agree. To me, icon_path should be some kind of environment variable, set once and for all. It should not be repeated every time we want to use an icon.
Now, if we don't want to introduce the new variable here, we still have to extract the path from somewhere... Let me refactor it a bit
There was a problem hiding this comment.
should be better now
yhuard
added
the
pr: review needed
emeryro
added
pr: under review
and removed
pr: review needed
emeryro
approved these changes
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
downloadproperty added totranslation.items. This new property lets you define a custom label and href for each translation.For convenience, there's also a new
icon_pathproperty which defaults toicon.pathin order to avoid breaking changes. This new property is used for the icons that can not be changed (e.g. the download icons, the arrow icon)