fix(footer): refactor markup. (#137)

ec-europa · Sep 18, 2019 · f645fb2 · f645fb2
1 parent ae75a07
commit f645fb2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/src/ec/packages/ec-component-footer/__snapshots__/footer.test.js.snap b/src/ec/packages/ec-component-footer/__snapshots__/footer.test.js.snap
@@ -185,7 +185,7 @@ exports[`EC - Footer Corporate renders correctly 1`] = `
       </div>
     </div>
   </div>
-  <section
+  <div
     class="ecl-footer__common"
   >
     <div
@@ -234,7 +234,7 @@ exports[`EC - Footer Corporate renders correctly 1`] = `
         Contact
       </a>
     </div>
-  </section>
+  </div>
 </footer>
 `;
 
@@ -425,7 +425,7 @@ exports[`EC - Footer Corporate renders correctly with extra attributes 1`] = `
       </div>
     </div>
   </div>
-  <section
+  <div
     class="ecl-footer__common"
   >
     <div
@@ -474,7 +474,7 @@ exports[`EC - Footer Corporate renders correctly with extra attributes 1`] = `
         Contact
       </a>
     </div>
-  </section>
+  </div>
 </footer>
 `;
 
@@ -663,7 +663,7 @@ exports[`EC - Footer Corporate renders correctly with extra class names 1`] = `
       </div>
     </div>
   </div>
-  <section
+  <div
     class="ecl-footer__common"
   >
     <div
@@ -712,7 +712,7 @@ exports[`EC - Footer Corporate renders correctly with extra class names 1`] = `
         Contact
       </a>
     </div>
-  </section>
+  </div>
 </footer>
 `;
 
@@ -1019,7 +1019,7 @@ exports[`EC - Footer Custom renders correctly 1`] = `
       </div>
     </div>
   </div>
-  <section
+  <div
     class="ecl-footer__common"
   >
     <div
@@ -1068,7 +1068,7 @@ exports[`EC - Footer Custom renders correctly 1`] = `
         Contact
       </a>
     </div>
-  </section>
+  </div>
 </footer>
 `;
 
@@ -1377,7 +1377,7 @@ exports[`EC - Footer Custom renders correctly with extra attributes 1`] = `
       </div>
     </div>
   </div>
-  <section
+  <div
     class="ecl-footer__common"
   >
     <div
@@ -1426,7 +1426,7 @@ exports[`EC - Footer Custom renders correctly with extra attributes 1`] = `
         Contact
       </a>
     </div>
-  </section>
+  </div>
 </footer>
 `;
 
@@ -1733,7 +1733,7 @@ exports[`EC - Footer Custom renders correctly with extra class names 1`] = `
       </div>
     </div>
   </div>
-  <section
+  <div
     class="ecl-footer__common"
   >
     <div
@@ -1782,6 +1782,6 @@ exports[`EC - Footer Custom renders correctly with extra class names 1`] = `
         Contact
       </a>
     </div>
-  </section>
+  </div>
 </footer>
 `;
diff --git a/src/ec/packages/ec-component-footer/footer.html.twig b/src/ec/packages/ec-component-footer/footer.html.twig
@@ -167,7 +167,7 @@
   </div>
 
   {# Common #}
-  <section class="ecl-footer__common">
+  <div class="ecl-footer__common">
     <div class="ecl-container ecl-footer__common-container">
       {% for item in _common %}
         {% include '../ec-component-link/link.html.twig' with item|merge({
@@ -181,7 +181,7 @@
         }) only %}
       {% endfor %}
     </div>
-  </section>
+  </div>
 </footer>
 
 {% endspaceless %}