Fix for #10 of Azure-Samples/function-image-upload-resize #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partly fixing the issues for MicrosoftDocs#10 (document related ones) and a few minor fixes 1. [1&2 / MicrosoftDocs#10] The connectionstring for the blob storage account should be a different parameter, so assuming the intent was to use BLOB_STORAGE_CONNECTION_STRING, added this as a parameter. The code should also check this parameter. (PR will follow) 2. [3/MicrosoftDocs#10] "THUMBNAIL_CONTAINER_NAME": "thumbnails", "THUMBNAIL_WIDTH": "100" are added as application settings 3. The new v2 code is not csx, so removed the link (which does not exist any more) 4. Fixed the documentation refers to the old `imageresizerfunc` whereas new function is called `Thumbnail`
ebrucucen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixing the issues for #10 (document related ones) and a few minor fixes
imageresizerfuncwhereas new function is calledThumbnail