Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature req] Suppress notification for some radio stations #54

Closed
guzzard opened this issue Mar 10, 2018 · 5 comments
Closed

[Feature req] Suppress notification for some radio stations #54

guzzard opened this issue Mar 10, 2018 · 5 comments
Assignees
@ebruck
Labels
Bookmark Editor enhancement

Comments

@guzzard
Copy link

guzzard commented Mar 10, 2018 •
edited
Loading

Would be really nice to be able to enable/disable notifications per radio stations in the station configuration. Some stations spam with ads etc in the notifications with very short intervals.
ebruck added a commit that referenced this issue Mar 10, 2018
@ebruck
Added per station notification toggle (#54)
11883db
@ebruck ebruck self-assigned this Mar 10, 2018
@ebruck
Copy link
Owner

ebruck commented Mar 10, 2018

@mburns83 please add editor support for the new toggle. thx!

ebruck added a commit that referenced this issue Mar 10, 2018
@ebruck
Added per station notification toggle (#54)
0f1e5b2
@ebruck
Copy link
Owner

ebruck commented Mar 19, 2018

@guzzard editor changes by @mburns83 have been merged into v0.2.2-dev. If you can build and test that would be very helpful.

@guzzard
Copy link
Author

guzzard commented Mar 19, 2018

Cool! Will test tonight!

@guzzard
Copy link
Author

guzzard commented Mar 19, 2018

@ebruck @mburns83 working great for me! Settings apply on bookmark refresh. Thanks!

@ebruck
Copy link
Owner

ebruck commented Mar 21, 2018 •
edited
Loading

@guzzard that's great. Thanks for testing!

@ebruck ebruck closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebruck ebruck

Labels
Bookmark Editor enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebruck @guzzard