Security vulnerabilities #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyb
force-pushed
the
security-vulnerabilities
branch
2 times, most recently
from
1761f1f to
a92a942
Compare
lucyb
force-pushed
the
security-vulnerabilities
branch
2 times, most recently
from
3f81b5c to
a6b9a69
Compare
This counts the number of vulnerability alerts that were either open or closed for any given date and any repo. Alerts are never deleted, they are either fixed or dismissed. These counts are then written to a db table. For some reason, the db table needs to have a column called "value". I'm not sure why and it's not being used at the moment. There is no paging on requests to the graphql api at the moment, so some repos in the ebmdatalab org will be getting missed. In future, we will miss some vulnerabilities too if we don't page the results. Archived repos are being included in the responses at the moment and should be removed.
This moves the entrypoint to the self-contained security.py module, which is then called directly from the dokku cron job.
lucyb
force-pushed
the
security-vulnerabilities
branch
from
a6b9a69 to
a76d0dd
Compare
ghickman
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This counts the number of vulnerability alerts that were either open or closed
for any given date and any repo. Alerts are never deleted, they are either
fixed or dismissed.
These counts are then written to a db table. For some reason, the db table
needs to have a column called "value". I'm not sure why and it's not being used
at the moment.
There is no paging on requests to the graphql api at the moment, so some repos
in the ebmdatalab org will be getting missed. In future, we will miss some
vulnerabilities too if we don't page the results.