Rework the open PRs data to measure at a specific point in time #54
+31
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbc
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now count all open PRs first thing each Monday morning (and still only include those which have been open for 7+ days at the point of counting).
Because we're now calculating "is this PR open" against a datetime I've exposed the *_at values from the API to compare against the point-in-time, keeping the date-based values since they're used in pr_throughput and a bit of open_prs still.
Does the
opened < dt < closedconstruct make sense to others? I've used it for a while but I'm never sure how obvious it is when someone else is reading.🚨NO BUCKETING WAS INVOLVED 🚨