Switch to bulk upsert #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghickman
force-pushed
the
always-be-backfillin
branch
from
9e3c6dd to
620667c
Compare
ghickman
force-pushed
the
bulk-upsert
branch
from
f68001c to
b702fce
Compare
psycopg can only send 65535 parameters in one go. Each values dict is currently 5 items, which means we end up with 10 parameters (name+value). Batching at 10k rows keeps the number of parameters under the limit.
ghickman
force-pushed
the
always-be-backfillin
branch
from
620667c to
91c6289
Compare
ghickman
force-pushed
the
bulk-upsert
branch
from
b702fce to
22459af
Compare
benbc
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're backfilling on every run it made sense to spend a bit of time optimising the database writes so local dev wasn't quite so slow. This switches us from executing one upsert (technically an
INSERT … ON CONFLICT SETin postgres) per row stored to a single upsert with N values.Locally this takes ingestion from ~3m50 to ~1m20.