Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill with graphql #50

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Backfill with graphql #50

merged 4 commits into from
Nov 28, 2023

Conversation

ghickman
Copy link
Contributor

This moves the github backfill command to using @benbc's GraphQL queries to pull the repos then PRs for a given org. I took a look at doing this in one query but consuming subpages added loads of complexity, and Ben had already written the other code, so easy win. The goal with moving to the GraphQL API for backfilling was to get the archivedAt value for repos, which isn't present in GitHub's REST API.

This matches how we're handling dates in the main CLI invocations.
This is terrible, but is expected to be a very temporary change.
@benbc
Copy link
Contributor

benbc commented Nov 28, 2023

Yeah, I decided that it was easier to have multiple queries and be able to cleanly abstract away the paging than trying to get it all in one query.

Copy link
Contributor

@benbc benbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a proper review later post-merge.

@ghickman ghickman merged commit 5fbb61d into main Nov 28, 2023
7 checks passed
@ghickman ghickman deleted the backfill-with-graphql branch November 28, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants