Rework open prs #27
Merged
Rework open prs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyb
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Looks good. As far as I can tell, it should be calculating the range of dates as you've described. Having more tests would obviously make that easier to determine. On that note, it looks like coverage hasn't been configured with source directories yet, would now be a good time?
|
We're at about 13% coverage if I enable proper coverage. I'll add tests once the system metrics stuff is done, captured in #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from Ben we're now collecting open PR data by week.
The main part to sense check in this change is the range for when I'm collecting data.
Given a date of X it should look at the most recent Monday -> Sunday (inclusive) range of dates.