directly test the GitHub metrics functions

tests/metrics/github/test_cli.py

@@ -1,8 +1,21 @@
 import textwrap
+from datetime import UTC, datetime, timedelta
 
 from click.testing import CliRunner
 
 from metrics.cli import cli
+from metrics.github.cli import old_prs, pr_throughput
+
+
+def ts(name, author, time, value):
+    return {
+        "time": time,
+        "value": value,
+        "name": name,
+        "author": author,
+        "repo": "metrics",
+        "organisation": "bennett",
+    }
 
 
 def test_github():
@@ -21,3 +34,151 @@ def test_github():
         """
     ).lstrip()  # lstrip so dedent works and we retain the leading newline
     assert result.output == expected, result.output
+
+
+def test_old_prs():
+    def pr(author, created, days_open):
+        created_at = datetime(2023, 11, created, tzinfo=UTC)
+        closed_at = created_at + timedelta(days=days_open)
+
+        return {
+            "org": "bennett",
+            "repo": "metrics",
+            "author": author,
+            "closed_at": closed_at,
+            "created_at": created_at,
+            "repo_archived_at": closed_at + timedelta(days=1),
+        }
+
+    week1 = [  # 2023-11-06 -> 2023-11-12
+        pr("bbc", created=1, days_open=8),
+        pr("bbc", created=7, days_open=1),
+        pr("bbc", created=10, days_open=1),
+        pr("george", created=2, days_open=9),
+        pr("george", created=3, days_open=7),
+        pr("george", created=9, days_open=1),
+        pr("george", created=10, days_open=1),
+        pr("george", created=11, days_open=1),
+        pr("lucy", created=5, days_open=7),
+        pr("tom", created=9, days_open=1),
+    ]
+    week2 = [  # 2023-11-13 -> 2023-11-19
+        pr("bbc", created=15, days_open=3),
+        pr("george", created=14, days_open=2),
+        pr("george", created=16, days_open=1),
+        pr("lucy", created=6, days_open=10),
+        pr("lucy", created=11, days_open=8),
+        pr("lucy", created=14, days_open=2),
+        pr("lucy", created=18, days_open=1),
+        pr("tom", created=9, days_open=8),
+        pr("tom", created=10, days_open=5),
+        pr("tom", created=15, days_open=2),
+    ]
+    week3 = [  # 2023-11-20 -> 2023-11-26
+        pr("bbc", created=15, days_open=9),
+        pr("george", created=21, days_open=2),
+        pr("lucy", created=16, days_open=10),
+        pr("lucy", created=16, days_open=9),
+        pr("lucy", created=16, days_open=8),
+        pr("lucy", created=16, days_open=7),
+        pr("lucy", created=24, days_open=3),
+        pr("lucy", created=25, days_open=2),
+        pr("lucy", created=25, days_open=3),
+        pr("tom", created=18, days_open=8),
+    ]
+    week4 = [  # 2023-11-27 -> 2023-12-03
+        pr("bbc", created=21, days_open=9),
+        pr("george", created=21, days_open=10),
+        pr("george", created=22, days_open=9),
+        pr("george", created=23, days_open=8),
+        pr("george", created=24, days_open=7),
+        pr("george", created=25, days_open=6),
+        pr("george", created=26, days_open=5),
+        pr("lucy", created=28, days_open=2),
+        pr("lucy", created=30, days_open=1),
+        pr("tom", created=24, days_open=9),
+    ]
+    prs = week1 + week2 + week3 + week4
+
+    outputs = list(old_prs(prs, "bennett", days_threshold=7))
+
+    def output_for_week(starting_day, outputs):
+        # break up the outputs to make them easier to work with when asserting
+        dt = datetime(2023, 11, starting_day)
+        return list(
+            sorted(
+                [row for row in outputs if row["time"] == dt],
+                key=lambda pr: pr["author"],
+            )
+        )
+
+    # we expect to only have timeseries (ts) rows people with counts of PRs
+    # which have been open past the threshold specified in the old_prs() call
+
+    # week 1
+    assert output_for_week(6, outputs) == [
+        ts("queue_older_than_7_days", "bbc", datetime(2023, 11, 6), 1),
+        ts("queue_older_than_7_days", "george", datetime(2023, 11, 6), 2),
+        ts("queue_older_than_7_days", "lucy", datetime(2023, 11, 6), 1),
+    ]
+
+    # week 2
+    assert output_for_week(13, outputs) == [
+        ts("queue_older_than_7_days", "lucy", datetime(2023, 11, 13), 2),
+        ts("queue_older_than_7_days", "tom", datetime(2023, 11, 13), 1),
+    ]
+
+    # week 3
+    assert output_for_week(20, outputs) == [
+        ts("queue_older_than_7_days", "bbc", datetime(2023, 11, 20), 1),
+        ts("queue_older_than_7_days", "lucy", datetime(2023, 11, 20), 4),
+        ts("queue_older_than_7_days", "tom", datetime(2023, 11, 20), 1),
+    ]
+
+    # week 4
+    assert output_for_week(27, outputs) == [
+        ts("queue_older_than_7_days", "bbc", datetime(2023, 11, 27), 1),
+        ts("queue_older_than_7_days", "george", datetime(2023, 11, 27), 4),
+        ts("queue_older_than_7_days", "tom", datetime(2023, 11, 27), 1),
+    ]
+
+
+def test_pr_throughput():
+    def pr(author, merged):
+        merged_at = datetime(2023, 11, merged)
+        return {
+            "org": "bennett",
+            "repo": "metrics",
+            "author": author,
+            "created_at": merged_at - timedelta(days=1),
+            "merged_at": merged_at,
+            "repo_archived_at": merged_at + timedelta(days=1),
+        }
+
+    prs = [
+        pr("george", merged=1),
+        pr("george", merged=1),
+        pr("george", merged=1),
+        pr("bbc", merged=1),
+        pr("bbc", merged=1),
+        pr("george", merged=2),
+        pr("bbc", merged=2),
+        pr("bbc", merged=2),
+        pr("bbc", merged=2),
+        pr("bbc", merged=2),
+    ]
+
+    # should have rows with expected counts
+    expected = [
+        ts("prs_merged", "bbc", datetime(2023, 11, 1), 2),
+        ts("prs_merged", "george", datetime(2023, 11, 1), 3),
+        ts("prs_merged", "bbc", datetime(2023, 11, 2), 4),
+        ts("prs_merged", "george", datetime(2023, 11, 2), 1),
+    ]
+
+    # the output so we can compare consistently
+    output = list(
+        sorted(pr_throughput(prs, "bennett"), key=lambda r: (r["time"], r["author"]))
+    )
+
+    assert output == expected