Fix percentiles #37
Merged
Fix percentiles #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The percentile boundaries generated by np.arange did not round correctly
when scaled up to integers.
Specifically:
>>> (np.arange(0.01, 0.1, 0.01) * 100).astype(int)
array([1, 2, 3, 4, 5, 6, 6, 8, 9])
>>> np.arange(0.01, 0.1, 0.01)[6]
0.06999999999999999
We work around this by specifying the percentile boundaries explicitly.
ccunningham101
approved these changes
Oct 17, 2023
Closed
|
Thanks @LFISHER7 and @ccunningham101 for your input on #31. Sorry it's taken us so long to address this. |
inglesp
added a commit
to opensafely-core/python-docker
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The percentile boundaries generated by np.arange did not round correctly when scaled up to integers.
Specifically:
We work around this by specifying the percentile boundaries explicitly.