Improve how errors related to package list update are presented on UI #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code review feedback suggested storing errors as Error objects and displaying them in modals when possible. - UtilityMixin: the background update process just throws the error as-is, since failing silently is the still the appropriate action - ImportProfileModal: show the error message as inline text, as we don't want to open the error modal while already in a modal - ModListUpdateBanner: Allow user to view the error details in a modal - SettingsView: show the error as inline text since returning markup from SettingsRow method doesn't really work
This improves readability on call sites and allows passing arguments without having to explicitly define all prior arguments that use the default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.