Refactor ImportProfileModal to support mod list updates #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to access the preview step ASAP as this is where user is likely to encounter problems with outdated or not loaded mod list.
Some call sites of the Vuex methods pass objects of wrong but compatible type to the methods. TypeScript doesn't pick up on this as the type support for the old Vuex version is non-existent. Extend the argument types so some later changes to methods don't break when the ExportMod object is passed.
The modal now shows a list of the known mods which can be installed, as well as a list of the names of the unknown mods. If there's no known mods, the import button is disabled. Option to cancel the import is always shown, in case user wants to cancel after seeing the contents of the profile. The main reason for combining the modals is to make it easier to provide an option for updating the mod list without leaving the modal. This became important after the recent changes, as the splash screen no longer guarantees that the mod list is loaded into Vuex.
SplashScreen no longer guarantees the online mod list has been loaded into the memory, or the list might be fetched from IndexedDB and be outdated. Profile import can't install mods that are not found in the memory. To remedy the issue, allow users to trigger mod list update directly from the profile import modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.