-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added button to copy launch arguments easier #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as I don't consider it a major issue, but the tooltip doesn't seem to work. Anyway I'd argue that tooltip that says the same as the button itself provides no value so it should be removed altogether.
src/pages/Help.vue
Outdated
<template v-if="doorstopTarget.length > 0"> | ||
<p> | ||
<button class="button" @click="copyDoorstopTargetToClipboard" v-if="!copyingDoorstopText"> | ||
<i class="fas fa-clipboard" v-tooltip.left="'Drag to reorder'"></i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Says "Drag to reorder". Anyway, I don't see this or the "Copy launch arguments" tooltip at all?
The tooltip was likely just from a bad copy/paste job on another item that had a tooltip. Will remove. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ebkr thank you! |
Resolves #1158
Screenshots