Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved online category filtering #1337

Merged
merged 2 commits into from
May 31, 2024
Merged

Improved online category filtering #1337

merged 2 commits into from
May 31, 2024

Conversation

ebkr
Copy link
Owner

@ebkr ebkr commented May 26, 2024

All three filtering options are now present alongside each other in the filter modal. The user no longer needs to select only one filter behaviour type.

It's a fairly common criticism that the app doesn't match the filter behaviour on the site.

This is still somewhat the case however expands to support the actual behaviour that people are after, which is to filter on both include and exclude.

The existing behaviour was for:

  • Contains at least one category
  • Contains all categories
  • Exclude category

These three are now present in the modal under tag selections as opposed to being a radio option.

Screenshots

image

…he filter modal. No longer need to select only one behaviour.
@ebkr ebkr requested review from anttimaki and MythicManiac May 26, 2024 16:36
@ebkr ebkr self-assigned this May 26, 2024
@ebkr ebkr removed the request for review from MythicManiac May 26, 2024 17:07
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM, but on the UI when multiple categories are selected, first the x-buttons drop onto their own lines, and then categories extend outside the modal.

image

@ebkr
Copy link
Owner Author

ebkr commented May 29, 2024

Good spot, this is now fixed:
image

The is-delete class comes with Bulma and replaces the content with the X so is being used instead of the font-awesome one. The Bulma one does however require that there's content beforehand, this is being done with a nbsp character. We could replace it with the font-awesome one however the alignment seems ever-so-slightly nicer this way.

Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebkr ebkr merged commit 5e93b1d into develop May 31, 2024
7 checks passed
@ebkr ebkr deleted the better-online-filtering branch May 31, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants