Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling to zip extracting when importing profiles #1323

Merged
merged 1 commit into from
May 27, 2024
Merged

Add error handling to zip extracting when importing profiles #1323

merged 1 commit into from
May 27, 2024

Conversation

VilppeRiskidev
Copy link
Collaborator

  • More precisely for the calls to ZipProvider.instance.extractEntryTo() in Profiles.vue page

@VilppeRiskidev
Add error handling to zip extracting when importing profiles
b15eae5 
- More precisely for the calls to ZipProvider.instance.extractEntryTo() in Profiles.vue page
@VilppeRiskidev VilppeRiskidev requested a review from anttimaki May 8, 2024 09:12
@VilppeRiskidev VilppeRiskidev self-assigned this May 8, 2024
anttimaki
anttimaki approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you test this manually by throwing an error to see that the event listener stuff didn't cause problems?

@anttimaki anttimaki merged commit 9760786 into develop May 27, 2024
7 checks passed
@anttimaki anttimaki deleted the zip-extract-error-handling branch May 27, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttimaki anttimaki anttimaki approved these changes

Assignees

@VilppeRiskidev VilppeRiskidev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VilppeRiskidev @anttimaki