Prevent multiple simultaneous package list updates #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be no point in waiting to do this check, so do it as early as possible. This also makes the first function to only do the update and consolidates all the auxiliary stuff into the second function.
Online mod list is currently updated on the background every 5 minutes. Ideally downloading and processing the mod list wouldn't take that long that the interval would fire before an earlier round has finished, but the most popular games have so many mods that on people with slower connections this seems to happen. Multiple connections then compete for the same download bandwidth, making the process even slower.
Users can trigger updating the online mod list from the settings view. Use the status text to show if an update is already in progress and prevent user actions from triggering another one, since they would just compete for the same bandwidth and slow down the manager.
anttimaki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.