Use Vuex where feasible to access app state in Vue components #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of type support from Vuex makes this kinda sad though.
Read the active game, selected profile and settings object from Vuex.
Change the last places where activeGame is accessed via GameManager to use Vuex instead. After this two components still access GameManager directly: - GameSelectionScreen, which uses the classes' methods, not just the activeGame (these should be removed later though) - SettingsLoader, which is a special case where we want to be as fault-averse as possible. Adding Vuex to this feels like a bad choice GameManager is still accessed directly in non-component files.
Using warn for a event that oocurs every time user accesses the profile selection view for the first time is overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.