Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vuex items to more suitable modules #1278

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Move vuex items to more suitable modules #1278

merged 2 commits into from
Apr 15, 2024

Conversation

anttimaki
Copy link
Collaborator

No description provided.

@anttimaki anttimaki requested a review from MythicManiac March 20, 2024 14:57
The error is shown on the UI when manually triggered udpating of the
mod list from Thunderstore API fails, so the module which handles all
that is more suitable location for managing the error message.
The banner for updating all mods with updates is shown on the view
listing the mods in currently selected profile, so the module which
handles the rest of the profile related data is a more suitabl
location.
@anttimaki anttimaki marked this pull request as ready for review April 3, 2024 13:23
Copy link
Collaborator

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring

Base automatically changed from splash-progress to develop April 15, 2024 06:29
@anttimaki anttimaki merged commit 7d25d50 into develop Apr 15, 2024
7 checks passed
@anttimaki anttimaki deleted the move-vuex-items branch April 15, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants