Create dedicated components for mod modals #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create dedicated components for mod management modals (uninstall, disable, view assocaited). This commit does not move the state management anywhere yet, but ideally it too would be separated from the LocalModList.vue component. While this commit does increase the amount of boilerplate in the interim, it makes it easier to understand the state flow of the modals (especially inside the modal component itself) and leaves room for future changes that don't directly impact all of the modals.
ebkr
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated components for mod management modals (uninstall, disable, view assocaited). This commit does not move the state management anywhere yet, but ideally it too would be separated from the LocalModList.vue component.
While this commit does increase the amount of boilerplate in the interim, it makes it easier to understand the state flow of the modals (especially inside the modal component itself) and leaves room for future changes that don't directly impact all of the modals.