Remove version number from links leading to Thunderstore website #1140
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer communities have a different URL structure for showing a specific version of a package than the older communities that use subdomains. Installed mods tried to link to a specific version, but the links were broken for the new communities, which confused users. Always link to the non version specific page as a quick fix. A proper fix would require backend changes and/or an actual spec. One could sniff the base URL to determine how to link to a specific version, but this would be prone to break if the URL structure change again (e.g. once the new Thunderstore website is launched). Since the button doesn't lead to the actual installed version anymore, use "website" as the label instead of the version number. This is in line with how the non-installed mods currently link to the website. Since the version number needs to be shown somewhere, show it on the package title row instead.
|
MythicManiac
approved these changes
Jan 3, 2024
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer communities have a different URL structure for showing a specific version of a package than the older communities that use subdomains. Installed mods tried to link to a specific version, but the links were broken for the new communities, which confused users.
Always link to the non version specific page as a quick fix. A proper fix would require backend changes and/or an actual spec. One could sniff the base URL to determine how to link to a specific version, but this would be prone to break if the URL structure change again (e.g. once the new Thunderstore website is launched).
Since the button doesn't lead to the actual installed version anymore, use "website" as the label instead of the version number. This is in line with how the non-installed mods currently link to the website.
Since the version number needs to be shown somewhere, show it on the package title row instead.