Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major dep update #256

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Major dep update #256

wants to merge 8 commits into from

Conversation

aurel-l
Copy link
Contributor

@aurel-l aurel-l commented Mar 13, 2023

Purpose

Update to newest version libraries

Approach

  • Update to newest versions of React and some other libraries.
  • Aim for the Franklin library to be usable without too much custom logic in uniprot-website webpack config.
  • Remove unneeded libraries if possible

Testing

What test(s) did you write to validate and verify your changes?

Stories

What story(ies) did you write or change to document the functionality / changes?

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why
  • Were all the edited/created files in TypeScript? If not, please list the files you left in JavaScript and the reason to not update them.
  • For the stories you created/updated, are the props modifiables through knobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants