Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Saves to file experiments that actually pass the filter. Useful for d… #9

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

WIP Saves to file experiments that actually pass the filter. Useful for d… #9

wants to merge 1 commit into from

Conversation

pmb59
Copy link
Member

@pmb59 pmb59 commented Aug 27, 2021

…ebugging

@pmb59 pmb59 requested review from pcm32 and pinin4fjords August 27, 2021 11:10
pcm32
pcm32 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@pcm32 pcm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after addressing the path for the file.

Snakefile-sorting-hat
@@ -91,6 +91,10 @@ def get_outputs():
valid_acc_dir = next(os.walk( config['atlas_exps'] ))[1]
# intersection of the two lists
pass_ACC = list(set(ACC) & set(valid_acc_dir))
#save passing ACCs to file
with open('exps_tagged_for_processing.txt', 'w') as f:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but maybe you want to set the file path here from config, otherwise it will end up in the analysis directory from where it is getting experiments.

@pmb59 pmb59 changed the title Saves to file experiments that actually pass the filter. Useful for d… WIP Saves to file experiments that actually pass the filter. Useful for d… Sep 30, 2021
@pmb59 pmb59 marked this pull request as draft July 20, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcm32 pcm32 pcm32 approved these changes

@pinin4fjords pinin4fjords Awaiting requested review from pinin4fjords

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmb59 @pcm32