Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for ExperimentsConditionsDetailsController #224

Merged

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Dec 2, 2024

The 2 endpoints in ExperimentsConditionsDetailsController

  • /api/assaygroupsdetails.tsv
  • /api/contrastdetails.tsv

were not covered with tests at all.

This change adds those missing MVC tests to the controller.

@ke4 ke4 added Improvement Improve/refactor existing code technical debt Technical debt labels Dec 2, 2024
@ke4 ke4 self-assigned this Dec 2, 2024
@ke4 ke4 marked this pull request as ready for review December 2, 2024 14:55
@ke4 ke4 linked an issue Dec 2, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ke4 ke4 merged commit 4692542 into develop Dec 10, 2024
2 checks passed
@ke4 ke4 deleted the chore/add_missing_tests_for_ExperimentsConditionsDetailsController branch December 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improve/refactor existing code technical debt Technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tests for ExperimentsConditionsDetailsController class
2 participants