-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Set provided species parameter to GeneSearchForm #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run npx cypress run --component
I got failling tests unfortunatelly, please take a look too else.
packages/scxa-cell-type-wheel-experiment-heatmap/src/CellTypeWheelExperimentHeatmap.js
Show resolved
Hide resolved
@lingyun1010 For me all of the tests are passing. |
If the test is about the |
No, those tests are not testing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please remember to publish the npm packages for both scxa-gene-search-form
and scxa-cell-type-wheel-experiment
, and update the package.json
in the front-end and back-end bundles.
As we discussed with @lingyun1010 I update the |
Species parameter was ignored when it was provided as a URL request parameter.
With this change I set the species parameter on the
GeneSearchForm
and also pass it to theCellTypeWheelFetchLoader
.I also added 3 new test cases to cover these cases.