Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Set provided species parameter to GeneSearchForm #153

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Jul 12, 2024

Species parameter was ignored when it was provided as a URL request parameter.
With this change I set the species parameter on the GeneSearchForm and also pass it to the CellTypeWheelFetchLoader.
I also added 3 new test cases to cover these cases.

@ke4 ke4 added the bug Something isn't working label Jul 12, 2024
@ke4 ke4 requested a review from lingyun1010 July 12, 2024 12:20
@ke4 ke4 self-assigned this Jul 12, 2024
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run npx cypress run --component I got failling tests unfortunatelly, please take a look too else.

@ke4
Copy link
Contributor Author

ke4 commented Jul 15, 2024

@lingyun1010 For me all of the tests are passing.
I suspect you have not installed locally the scxa-gene-search-form dependency as I did some changes in that component, too.
Try to do that with this command locally in the scxa-cell-type-wheel-experiment-heatmap component folder:
npm install ../scxa-gene-search-form
And run the tests again. They should pass.

@lingyun1010
Copy link
Contributor

@lingyun1010 For me all of the tests are passing. I suspect you have not installed locally the scxa-gene-search-form dependency as I did some changes in that component, too. Try to do that with this command locally in the scxa-cell-type-wheel-experiment-heatmap component folder: npm install ../scxa-gene-search-form And run the tests again. They should pass.

If the test is about the gene-search-form then I think those tests should be included in that component, rather than in this one.

@ke4
Copy link
Contributor Author

ke4 commented Jul 16, 2024

@lingyun1010 For me all of the tests are passing. I suspect you have not installed locally the scxa-gene-search-form dependency as I did some changes in that component, too. Try to do that with this command locally in the scxa-cell-type-wheel-experiment-heatmap component folder: npm install ../scxa-gene-search-form And run the tests again. They should pass.

If the test is about the gene-search-form then I think those tests should be included in that component, rather than in this one.

No, those tests are not testing the gene-search-form. I just added some selectors to that component's UI elements. That's all.

lingyun1010
lingyun1010 previously approved these changes Jul 18, 2024
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please remember to publish the npm packages for both scxa-gene-search-form and scxa-cell-type-wheel-experiment, and update the package.json in the front-end and back-end bundles.

@ke4
Copy link
Contributor Author

ke4 commented Jul 18, 2024

As we discussed with @lingyun1010 I update the package.json of scxa-cell-type-wheel-experiment-heatmap with the latest published version of scxa-gene-search-form and committed/pushed it to this PR.

@ke4 ke4 merged commit 337c9e2 into master Jul 18, 2024
@ke4 ke4 deleted the bugfix/pass_species_parameter_to_cell_type_wheel branch July 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants