Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zod to the benchmark #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ilanashapiro
Copy link

@ilanashapiro ilanashapiro commented May 11, 2023

Addresses issue #66

zod is quickly growing in popularity as a json-schema validator. It is now added to the benchmark so it can be compared with the other validators.

Result of running node index.js in the terminal (zod is highlighted). I commented out the part of the code that limits the logging to the top 6 results, so that all validators are shown for comparison. Also note that the current sorting (which I did not modify) is from least to greatest number of failing tests.

Draft 7 test suite:
draft7

Draft 6 test suite:
draft6

Draft 4 test suite:
draft4

@ilanashapiro
Copy link
Author

@rattrayalex

@ilanashapiro
Copy link
Author

@ebdrup

@rattrayalex
Copy link

Thanks Ilana! Would you mind updating the PR description with a second screenshot, showing how zod compares against others in the benchmark on your laptop?

@ilanashapiro
Copy link
Author

@rattrayalex updated!

@ilanashapiro
Copy link
Author

@ChALkeR

@ChALkeR
Copy link
Contributor

ChALkeR commented May 16, 2023

@ilanashapiro hm?
I don't have commit rights here.

@ilanashapiro
Copy link
Author

ilanashapiro commented May 16, 2023

@ChALkeR oh my apologies, never mind then, I was looking through the commit history for this repo and I thought you were added as a collaborator with write access. If you do know of someone with write access that could review this, it would be great if you could link them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants